Thanks a lot Pubudu! I reviewed it - it is a cleaner solution now.
On Wed, May 27, 2015 at 6:33 PM, Pubudu Gunatilaka <pubu...@wso2.com> wrote: > I changed the files and committed to the same branch. Please review and > merge. > > Thank you! > > On Wed, May 27, 2015 at 4:53 PM, Pubudu Gunatilaka <pubu...@wso2.com> > wrote: > >> The requirement here was to get deployment policies and applications >> policies. I will change this to be done at Stratos Manager so that there >> won't be any calls from CC to AS. >> >> Thank you! >> >> On Wed, May 27, 2015 at 4:40 PM, R-Rajkumar <g...@git.apache.org> wrote: >> >>> Github user R-Rajkumar commented on a diff in the pull request: >>> >>> https://github.com/apache/stratos/pull/362#discussion_r31122756 >>> >>> --- Diff: >>> components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java >>> --- >>> @@ -1524,6 +1529,53 @@ public boolean removeNetworkPartition(String >>> networkPartitionId) throws NetworkP >>> return true; >>> } >>> >>> + private void validateNetworkPartition(String >>> networkPartitionId) { >>> + >>> + try { >>> + DeploymentPolicy[] deploymentPolicies = >>> AutoscalerServiceClient.getInstance().getDeploymentPolicies(); >>> + >>> --- End diff -- >>> >>> We shouldn't call AS service from CC >>> >>> >>> --- >>> If your project is set up for it, you can reply to this email and have >>> your >>> reply appear on GitHub as well. If your project does not have this >>> feature >>> enabled and wishes so, or if the feature is enabled but not working, >>> please >>> contact infrastructure at infrastruct...@apache.org or file a JIRA >>> ticket >>> with INFRA. >>> --- >>> >> >> >> >> -- >> >> *Pubudu Gunatilaka* >> Software Engineer >> WSO2, Inc.: http://wso2.com >> lean.enterprise.middleware >> mobile: +94 77 4078049 >> > > > > -- > > *Pubudu Gunatilaka* > Software Engineer > WSO2, Inc.: http://wso2.com > lean.enterprise.middleware > mobile: +94 77 4078049 > -- Rajkumar Rajaratnam Committer & PMC Member, Apache Stratos Software Engineer, WSO2 Mobile : +94777568639 Blog : rajkumarr.com
