Hi Swapnil, Now it looks much better, I guess you are not using IDE features to auto generate the method comment text:
/* * Returns all the listeners attached to the load balancer. * Useful while deciding if all the listeners are necessary or some should be removed. */ public List<Listener> getAttachedListeners(String loadBalancerName) The method parameters are missing in most of the comments. On Sat, Jun 6, 2015 at 11:47 AM, Swapnil Patil <swapnil.r...@gmail.com> wrote: > Hi Imesh, > > I have already added comments. Sorry, forgot to let you know. > > Please let me know if those are sufficient or I should write in more > detail. > > GitHub URL: > https://github.com/swaprp15/stratos/tree/master/extensions/load-balancer/aws-extension/src/main/java/org/apache/stratos/aws/extension > > Thanks and Regards, > Swapnil > > On Fri, Jun 5, 2015 at 7:05 PM, Imesh Gunaratne <im...@apache.org> wrote: > >> Thanks Swapnil, please let me know once you are done. >> >> On Wed, Jun 3, 2015 at 9:13 PM, Swapnil Patil <swapnil.r...@gmail.com> >> wrote: >> >>> Hi Imesh, >>> >>> Sure, I will add comments for each method. >>> >>> registerInstancesToLoadBalancer() method will be helpful to attach any >>> new instances, spawned within a cluster, to the load balancer associated >>> with that cluster. >>> >>> Thanks and Regards, >>> Swapnil >>> >>> On Wed, Jun 3, 2015 at 12:35 PM, Imesh Gunaratne <im...@apache.org> >>> wrote: >>> >>>> Hi Swapnil, >>>> >>>> Great work! Will it be possible for you to add method comments to >>>> AWSHelper class and explain the functionality you have implemented? I did >>>> not get the purpose of the registerInstancesToLoadBalancer() method. >>>> >>>> Thanks >>>> >>>> On Sun, May 31, 2015 at 8:02 PM, Swapnil Patil <swapnil.r...@gmail.com> >>>> wrote: >>>> >>>>> Hi, >>>>> >>>>> This week I started coding. I am committing code changes at Github >>>>> repository [1]. Currently I am writing code for configure method of >>>>> AWSLoadBalancer. In that I have added logic to create AWS load balancer >>>>> and >>>>> registering and de-registering instances to it. I will try to finish the >>>>> configure method by coming week. >>>>> >>>>> I have also analysed the code changes needed to expose instanceId from >>>>> cloud controller through topology changes. I will make these changes in >>>>> coming week. >>>>> >>>>> [1] : >>>>> https://github.com/swaprp15/stratos/tree/master/extensions/load-balancer/ >>>>> aws-extension >>>>> >>>>> Thanks and Regards, >>>>> Swapnil >>>>> >>>> >>>> >>>> >>>> -- >>>> Imesh Gunaratne >>>> >>>> Senior Technical Lead, WSO2 >>>> Committer & PMC Member, Apache Stratos >>>> >>> >>> >> >> >> -- >> Imesh Gunaratne >> >> Senior Technical Lead, WSO2 >> Committer & PMC Member, Apache Stratos >> > > -- Imesh Gunaratne Senior Technical Lead, WSO2 Committer & PMC Member, Apache Stratos
