Github user chamilad commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/414#discussion_r35941444
  
    --- Diff: 
components/org.apache.stratos.python.cli/src/main/python/cli/Configs.py ---
    @@ -0,0 +1,14 @@
    +import os
    +
    +stratos_prompt = "stratos> "
    +
    +stratos_dir = "~/.stratos"
    +log_file_name = "stratos-cli.log"
    +
    +stratos_dir_path = os.path.expanduser(stratos_dir)
    +log_file_path = os.path.join(stratos_dir_path, log_file_name)
    +
    +stratos_url = os.getenv('STRATOS_URL', "https://localhost:9443/";)
    --- End diff --
    
    Are these configurable options by the user? If they are there shouldn't be 
code here. Better go for a config file such as an *.ini file and read from it. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to