GitHub user Thanu opened a pull request:
https://github.com/apache/stratos/pull/459
Cleaning and Formatting
This P/R includes cleaning and formatting some classes in Cloud-Controller.
Following changes are included:
1. Fix for SonarQube Analysis issues:
remove unused imports and variables - CloudControllerConfig
modifier public, abstract is redundant for interface methods -
PartitionValidator
removing unused constants - CloudControllerConstants
adding param tag - CloudControllerServiceUtil
local variable isValid is redundant - CloudControllerServiceUtil
local variable iaas is redundant - CloudControllerUtil
for loop replaceable with foreach loop - CloudControllerUtil
removing unused methods - CloudControllerUtil
String concatenation as argument to StringBuilder.append() call -
CloudControllerUtil
removing unused variable context - CloudControllerUtil
removing unused methods - CloudControllerUtil
2. Formatting code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Thanu/stratos refactoring-v4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/stratos/pull/459.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #459
----
commit ce76da72777b7c24aa8b41cb371eeaebe11862c3
Author: Thanuja <[email protected]>
Date: 2015-08-20T09:54:56Z
Cleaning and Formatting
Conflicts:
components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/util/CloudControllerUtil.java
commit f82415bde1cc26b4ffaa26c5f94dc7e93f54640e
Author: Thanuja <[email protected]>
Date: 2015-08-31T12:10:44Z
Removing unused methods in CloudControllerUtil
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---