Github user swgkg commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/464#discussion_r39477594
  
    --- Diff: 
components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/util/converter/ObjectConverter.java
 ---
    @@ -1147,15 +1151,18 @@ public static ApplicationBean 
convertStubApplicationContextToApplicationDefiniti
             if (applicationContext == null) {
                 return null;
             }
    -
    +        Application application = 
ApplicationManager.getApplications().getApplication(applicationContext.getApplicationId());
             ApplicationBean applicationDefinition = new ApplicationBean();
             
applicationDefinition.setApplicationId(applicationContext.getApplicationId());
             applicationDefinition.setAlias(applicationContext.getAlias());
             
applicationDefinition.setMultiTenant(applicationContext.getMultiTenant());
             applicationDefinition.setName(applicationContext.getName());
             
applicationDefinition.setDescription(applicationContext.getDescription());
    -        applicationDefinition.setStatus(applicationContext.getStatus());
    -
    +        if 
(application.getStatus().name().equals(APPLICATION_STATUS_ACTIVE)) {
    --- End diff --
    
    Can't we reuse the ApplicationStatus enum without declaring the additional 
constant of APPLICATION_STATUS_ACTIVE?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to