PCA live tests were failing due to not having enough threads in the thread pool. It is not the CEP HA mode test case but the agent startup test case which was failing as it was waiting for the complete topology event to receive. The event listener could not be started due to lack of threads.
I increased the thread pool size and make it configurable so that we can increase the thread pool size when needed. I also fixed some of issues we had in test cases with commit - 443f20aefe5c77a826f9f0b2a95d1aee8b40f4da. Thank you! On Thu, Nov 12, 2015 at 12:24 AM, Akila Ravihansa Perera <raviha...@wso2.com > wrote: > Thanks Pubudu! > Yes, I think it's better to use > IOUtils.toString(classLoader.getResourceAsStream(fileName)) to read the > config files here. > > I'm seeing lot of code duplication warnings in all test cases. We might > have to refactor the agent test cases. > > Thanks. > > On Wed, Nov 11, 2015 at 11:47 PM, Pubudu Gunatilaka <pubu...@wso2.com> > wrote: > >> Hi, >> >> I will look into this. We may have to change [1] as well. >> >> [1] - >> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/PythonAgentIntegrationTest.java#L130 >> >> Thank you! >> >> On Wed, Nov 11, 2015 at 7:05 PM, Akila Ravihansa Perera < >> raviha...@wso2.com> wrote: >> >>> Hi, >>> >>> Looks like PCA live test case for CEPHAModeTestCase is failing. Noticed >>> few issues in this test case. >>> >>> - Calling read() method in FIS does not guarantee that complete file is >>> loaded [1] >>> - cepPort + 1 is confusing. Use a public const with the actual value [2] >>> - Method name should be fixed to reflect the test case [3] >>> - Always add proper logs with information needed to troubleshoot if the >>> test case fails [4, 5] >>> >>> Shall we fix these issues please? >>> >>> [1] >>> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L87 >>> >>> [2] >>> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L96 >>> >>> [3] >>> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L73 >>> >>> [4] >>> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L259 >>> >>> [5] >>> https://github.com/apache/stratos/blob/stratos-4.1.x/products/python-cartridge-agent/modules/integration/test-integration/src/test/java/org/apache/stratos/python/cartridge/agent/integration/tests/CEPHAModeTestCase.java#L160 >>> >>> >>> Thanks. >>> >>> -- >>> Akila Ravihansa Perera >>> WSO2 Inc.; http://wso2.com/ >>> >>> Blog: http://ravihansa3000.blogspot.com >>> >> >> >> >> -- >> *Pubudu Gunatilaka* >> Committer and PMC Member - Apache Stratos >> Software Engineer >> WSO2, Inc.: http://wso2.com >> mobile : +94774079049 <%2B94772207163> >> >> > > > -- > Akila Ravihansa Perera > WSO2 Inc.; http://wso2.com/ > > Blog: http://ravihansa3000.blogspot.com > -- *Pubudu Gunatilaka* Committer and PMC Member - Apache Stratos Software Engineer WSO2, Inc.: http://wso2.com mobile : +94774079049 <%2B94772207163>
