On Fri, Nov 27, 2015 at 11:35 AM, Isuru Haththotuwa <isu...@apache.org> wrote:
> Hi, > > On Fri, Nov 27, 2015 at 11:13 AM, Gayan Gunarathne <gay...@wso2.com> > wrote: > >> Hi, >> >> On Fri, Nov 27, 2015 at 6:34 AM, Isuru Haththotuwa <isu...@apache.org> >> wrote: >> >>> Hi Devs, >>> >>> Currently for a multiTenant Application (multiTenant=true), when a >>> signup is removed, all artifacts which are in the local repository path >>> will be deleted from the file system. >>> >> But there are some cases where the runtime of the cartridge instance >>> depends on some of the artifacts which were originally there, and without >>> those artifacts, the cartridge instance runtime would not function >>> properly. I suggest the following to handle this: >>> >>> >>> 1. Prior to the first clone, take a backup of the artifacts in the >>> local repository path to a temporary location >>> 2. When the signup is removed, clean all the artifacts which had >>> been cloned to the local repository path location (from the git >>> repository >>> which was provided when signing up), and restore the artifacts (copy them >>> back from the backup location to local repository path) >>> >>> This will ensure the state of the instance after removal of the signup >>> is equivalent to the state before the signup was created. WDYT? >>> >> >> I assume this is happened for the super tenant sign ups only.Other >> tenants it works fine. Isn't? So we need to do consider this if is only the >> super tenant sign up. >> > We can implement this generically for all single tenant and multi tenant > signup removal, without explicitly checking. IMHO that is the best way. > Let 's think about this flow, First Tenant 1 is signup and we are making a backup for this signup. Then super tenant signup. Then again we have a back up for this as well.Then tenant 1 is going to remove his signup. Then what is the backup we are going to restore? For me it is difficult to maintain for this for each tenant. If we consider this only for the super tenant only we need to back up only when the super tenant sign up. We only need to restore the backup only the case of signup removal of the super tenant. >> >>> -- >>> Thanks and Regards, >>> >>> Isuru H. >>> +94 716 358 048* <http://wso2.com/>* >>> >>> >>> >> >> >> -- >> >> Gayan Gunarathne >> Technical Lead, WSO2 Inc. (http://wso2.com) >> Committer & PMC Member, Apache Stratos >> email : gay...@wso2.com | mobile : +94 775030545 >> >> -- >> <%2B94%20766819985> >> <%2B94%20766819985> >> Thanks and Regards, >> >> Isuru H. >> <%2B94%20766819985> >> +94 716 358 048 <%2B94%20766819985>* <http://wso2.com/>* >> >> >> * <http://wso2.com/>* >> >> >> -- Gayan Gunarathne Technical Lead, WSO2 Inc. (http://wso2.com) Committer & PMC Member, Apache Stratos email : gay...@wso2.com | mobile : +94 775030545 <%2B94%20766819985>
