Github user imesh commented on a diff in the pull request:
https://github.com/apache/stratos/pull/380#discussion_r46095170
--- Diff:
components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java
---
@@ -1396,7 +1396,8 @@ public static void addApplication(ApplicationBean
appDefinition, ConfigurationCo
usedCartridgeGroups.toArray(new
String[usedCartridgeGroups.size()]));
} catch (AutoscalerServiceApplicationDefinitionExceptionException
e) {
- throw new RestAPIException(e);
+ String message =
e.getFaultMessage().getApplicationDefinitionException().getMessage();
--- End diff --
I think we may not need to handle null here, because if a NPE is raised it
means that an error message raised by the Autoscaler service is not sent back
to the client properly. If so we need to fix that problem. If we add a null
check it would return a blank error message to the client.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
