Github user ravihansa3000 commented on a diff in the pull request:
https://github.com/apache/stratos/pull/496#discussion_r46106127
--- Diff:
components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftStatisticsPublisher.java
---
@@ -85,11 +85,13 @@ private void init() {
ArrayList<ReceiverGroup> receiverGroups = new
ArrayList<ReceiverGroup>();
for (ThriftClientInfo thriftClientInfo : thriftClientInfoList) {
- ArrayList<DataPublisherHolder> dataPublisherHolders = new
ArrayList<DataPublisherHolder>();
- DataPublisherHolder aNode = new DataPublisherHolder(null,
buildUrl(thriftClientInfo), thriftClientInfo.getUsername(),
thriftClientInfo.getPassword());
- dataPublisherHolders.add(aNode);
- ReceiverGroup group = new ReceiverGroup(dataPublisherHolders);
- receiverGroups.add(group);
+ if (thriftClientInfo.isStatsPublisherEnabled()) {
+ ArrayList<DataPublisherHolder> dataPublisherHolders = new
ArrayList<DataPublisherHolder>();
--- End diff --
Why is ArrayList dataPublisherHolders created inside the for loop?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
