[ 
https://issues.apache.org/jira/browse/STRATOS-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031466#comment-15031466
 ] 

ASF GitHub Bot commented on STRATOS-1632:
-----------------------------------------

Github user Thanu commented on a diff in the pull request:

    https://github.com/apache/stratos/pull/496#discussion_r46115971
  
    --- Diff: 
components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftStatisticsPublisher.java
 ---
    @@ -85,11 +85,13 @@ private void init() {
             ArrayList<ReceiverGroup> receiverGroups = new 
ArrayList<ReceiverGroup>();
     
             for (ThriftClientInfo thriftClientInfo : thriftClientInfoList) {
    -            ArrayList<DataPublisherHolder> dataPublisherHolders = new 
ArrayList<DataPublisherHolder>();
    -            DataPublisherHolder aNode = new DataPublisherHolder(null, 
buildUrl(thriftClientInfo), thriftClientInfo.getUsername(), 
thriftClientInfo.getPassword());
    -            dataPublisherHolders.add(aNode);
    -            ReceiverGroup group = new ReceiverGroup(dataPublisherHolders);
    -            receiverGroups.add(group);
    +            if (thriftClientInfo.isStatsPublisherEnabled()) {
    +                ArrayList<DataPublisherHolder> dataPublisherHolders = new 
ArrayList<DataPublisherHolder>();
    +                DataPublisherHolder aNode = new DataPublisherHolder(null, 
buildUrl(thriftClientInfo), thriftClientInfo.getUsername(), 
thriftClientInfo.getPassword());
    +                dataPublisherHolders.add(aNode);
    +                ReceiverGroup group = new 
ReceiverGroup(dataPublisherHolders);
    --- End diff --
    
    Fixed in commit 0483fe6e3fc4a3be1227272c26d500bedf2495a3


> DataPublisher objects are created for nodes which has statsPublisherEnabled 
> set to false in thrift-client-config.xml
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: STRATOS-1632
>                 URL: https://issues.apache.org/jira/browse/STRATOS-1632
>             Project: Stratos
>          Issue Type: Bug
>    Affects Versions: 4.1.4, 4.1.5
>            Reporter: Thanuja Uruththirakodeeswaran
>
>  When we have enabled stats publishing for one node and disabled for another 
> node in thrift-client-config.xml file, Stratos is trying to publish data to 
> both nodes. This is because when creating load balancing type data publisher, 
> it is creating DataPublisher for ThriftClientInfo object which has false 
> value set to statsPublisherEnabled attribute.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to