Github user Thanu commented on a diff in the pull request:
https://github.com/apache/stratos/pull/496#discussion_r46128897
--- Diff:
components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftStatisticsPublisher.java
---
@@ -83,25 +83,28 @@ private void init() {
private ArrayList<ReceiverGroup> getReceiverGroups() {
ArrayList<ReceiverGroup> receiverGroups = new
ArrayList<ReceiverGroup>();
+ ArrayList<DataPublisherHolder> dataPublisherHolders = new
ArrayList<DataPublisherHolder>();
+ DataPublisherHolder aNode;
for (ThriftClientInfo thriftClientInfo : thriftClientInfoList) {
- ArrayList<DataPublisherHolder> dataPublisherHolders = new
ArrayList<DataPublisherHolder>();
- DataPublisherHolder aNode = new DataPublisherHolder(null,
buildUrl(thriftClientInfo), thriftClientInfo.getUsername(),
thriftClientInfo.getPassword());
- dataPublisherHolders.add(aNode);
- ReceiverGroup group = new ReceiverGroup(dataPublisherHolders);
- receiverGroups.add(group);
+ if (thriftClientInfo.isStatsPublisherEnabled()) {
+ aNode = new DataPublisherHolder(null,
buildUrl(thriftClientInfo), thriftClientInfo.getUsername(),
--- End diff --
Yes, we don't need a reference object and can add new DataPublisherHolder
object to dataPublisherHolders list. Removed it and added unit test in commit
40eabcc6dfbbc3dd35de98660d0d5a0d00330417.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
