Hi, @Johannes: Does it work on your machine? It still does not work on my computer. The commit you mentioned was to fix a bug that occurred when the component started. The problem is that the labels are not shown in the UI. See the attached screenshot.
> On 4. Feb 2020, at 21:20, Dominik Riemer <[email protected]> wrote: > > Great! > So I guess this was just Philipp's way to ask for a code review :D > > -----Original Message----- > From: Johannes Tex <[email protected]> > Sent: Tuesday, February 4, 2020 9:16 PM > To: [email protected] > Subject: Re: Refactor MQTT based adapters > > Hi Philipp > > I took a quick look and tried to use the NetioMQTTAdapter with > "Labels.withId". It has worked as expected. I guess you already fixed it with > your commit "Add null check for alternative labels in label generator" :) > > Johannes > > On 2020/02/04 16:00:07, Philipp Zehnder <[email protected]> wrote: >> Hi all, >> >> since we have multiple adapters that use MQTT I created a utils class with >> all the code required for the configuration parameters. >> One of the new adapters is the NetioMQTTAdapter. The adapter itself works, >> but the labels are not shown in the UI. >> >> Maybe someone knows what the problem could be? >> It works when I use the old labels with Labels.from. >> When I use the new labels with Labels.withId it does not work. I think the >> problem is with the alternative static properties, since it also works when >> I remove them from the adapter description. >> Please write if anyone has a hint what the problem might be. >> >> >> Philipp >> >> >> >
