bossenti commented on a change in pull request #38:
URL:
https://github.com/apache/incubator-streampipes-extensions/pull/38#discussion_r603119705
##########
File path:
streampipes-processors-transformation-jvm/src/main/java/org/apache/streampipes/processors/transformation/jvm/processor/booloperator/logical/BooleanOperatorProcessor.java
##########
@@ -42,7 +44,14 @@ public DataProcessorDescription declareModel() {
.create()
.requiredProperty(EpRequirements.anyProperty())
.build())
-
.requiredTextParameter(Labels.withId(BOOLEAN_PROCESSOR_INPUT_KEY))
+
.requiredSingleValueSelection(Labels.withId(BOOLEAN_OPERATOR_TYPE),
Options.from(
+ BooleanOperatorType.AND.operator(),
+ BooleanOperatorType.OR.operator(),
+ BooleanOperatorType.NOT.operator(),
+ BooleanOperatorType.XOR.operator(),
+ BooleanOperatorType.X_NOR.operator(),
+ BooleanOperatorType.NOR.operator()))
Review comment:
Great, that looks fine.
To let the user select a set of properties, see the suggestion in line 45.
##########
File path:
streampipes-processors-transformation-jvm/src/main/java/org/apache/streampipes/processors/transformation/jvm/processor/booloperator/logical/BooleanOperatorProcessor.java
##########
@@ -42,7 +44,14 @@ public DataProcessorDescription declareModel() {
.create()
.requiredProperty(EpRequirements.anyProperty())
Review comment:
```suggestion
.requiredPropertyWithUnaryMapping(EpRequirements.booleanReq(), LABEL, DESC,
PropertyScope.NONE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
