Hi all, I did some refactoring in the connect modules, see [1], I tested everything and I will merge it into dev.
Most of the changes are within the module, but I also simplified how the description of adapters is stored and exchanged between the services. We used to store protocol descriptions and specific adapters separately, requiring a lot of if/else blocks in the code. I harmonized this, from now on we only have AdapterDescriptions (SpecificAdapterDescriptions / GenericAdapterDescriptions). A worker now provides a list of AdapterDescriptions to the backend instead of ConnectWorkerContainer object. Those changes include some updates in the database, so please clean your development system when pulling the new changes. Philipp [1] https://issues.apache.org/jira/projects/STREAMPIPES/issues/STREAMPIPES-438 > On 6. Oct 2021, at 10:18, Patrick Wiener <[email protected]> wrote: > > +1 > > def makes sense to harmonize everything to reduce complexity. > > Patrick > >> Am 06.10.2021 um 09:09 schrieb Philipp Zehnder <[email protected]>: >> >> Hi Dominik, >> >> ok great. I set them to deprecated in the branch I am currently working in >> [1]. >> I also changed it for the module ’streampipes-connect-adapters’ in the >> extensions project. >> We should also update all extension modules before the next release. >> >> Philipp >> >> [1] https://github.com/apache/incubator-streampipes/tree/STREAMPIPES-438 >> <https://github.com/apache/incubator-streampipes/tree/STREAMPIPES-438> >> >> >>> On 5. Oct 2021, at 14:47, Dominik Riemer <[email protected]> wrote: >>> >>> Hi Philipp, >>> >>> I think we can harmonize this and depreacte Adapter+Standalone submitters - >>> having these three options is just an intermediate step until we have a >>> single unified interface for managing extensions services. >>> >>> Dominik >>> >>> >>> On 2021/10/04 14:51:55, Philipp Zehnder <[email protected]> wrote: >>>> Hi all, >>>> >>>> currently we have three options to implement an extension module: >>>> * AdapterWorkerContainer >>>> * ExtensionsModelSubmitter >>>> * StandaloneModelSubmitter >>>> >>>> My suggestion would be to start harmonizing them into one option >>>> “ExtensionsModelSubmitter” and set the other options to deprecated. >>>> I’ll create an issue and branch for this and start refactoring the modules >>>> in the extensions git project. >>>> >>>> Is there anything I should keep in mind when making the changes? >>>> >>>> Philipp >>>> >>>> >> >
