dominikriemer commented on code in PR #101:
URL:
https://github.com/apache/incubator-streampipes/pull/101#discussion_r935174733
##########
streampipes-extensions/streampipes-sinks-internal-jvm/pom.xml:
##########
@@ -56,6 +56,7 @@
</dependency>
<!-- External dependencies -->
+ <!-- TODO remove after refactoring -->
Review Comment:
remove comment
##########
streampipes-platform-services/src/main/java/org/apache/streampipes/ps/DataLakeResourceV4.java:
##########
@@ -43,10 +43,6 @@
import static
org.apache.streampipes.dataexplorer.v4.SupportedDataLakeQueryParameters.*;
-class Placeholder {
Review Comment:
I think this is needed for the Swagger API doc generation to work
##########
streampipes-data-explorer/src/main/java/org/apache/streampipes/dataexplorer/DataLakeNoUserManagementV3.java:
##########
@@ -39,7 +42,9 @@ public boolean addDataLake(String measure, EventSchema
eventSchema) {
return false;
}
} else {
- getDataLakeStorage().storeDataLakeMeasure(new DataLakeMeasure(measure,
eventSchema));
+ DataLakeMeasure dataLakeMeasure = new DataLakeMeasure(measure,
eventSchema);
+ dataLakeMeasure.setSchemaVersion(DataLakeMeasure.CURRENT_SCHEMA_VERSION);
Review Comment:
Can the current schema version be set automatically in the constructor for
new instances?
##########
streampipes-extensions/streampipes-sinks-internal-jvm/pom.xml:
##########
@@ -64,6 +65,8 @@
<groupId>org.influxdb</groupId>
<artifactId>influxdb-java</artifactId>
</dependency>
+ <!-- TODO remove after refactoring -->
Review Comment:
remove comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
