obermeier opened a new pull request, #1945:
URL: https://github.com/apache/streampipes/pull/1945
<!--
~ Licensed to the Apache Software Foundation (ASF) under one or more
~ contributor license agreements. See the NOTICE file distributed with
~ this work for additional information regarding copyright ownership.
~ The ASF licenses this file to You under the Apache License, Version 2.0
~ (the "License"); you may not use this file except in compliance with
~ the License. You may obtain a copy of the License at
~
~ http://www.apache.org/licenses/LICENSE-2.0
~
~ Unless required by applicable law or agreed to in writing, software
~ distributed under the License is distributed on an "AS IS" BASIS,
~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
~ See the License for the specific language governing permissions and
~ limitations under the License.
~
-->
### Purpose
I think we have verry nice examples how to use the StreamPipes Python
client. I have a suggestion on how to improve the user experience further
related to Kafka configuration for less experienced users .
In the given example localhost as hostname is used. I think this could lead
to the assumtion that abitrary hostnamames or IPs are possible by default.
For this reason I suggest to add a small hint for non Kafka experianced user
that the exernal adress schould be advertised by kafka by ajusting
KAFKA_ADVERTISED_LISTENERS.
Example for the docker-compose env: ` KAFKA_ADVERTISED_LISTENERS:
PLAINTEXT://:9092,OUTSIDE://{EXTERNAL_ADDRESS}:9094`
"What do you think of this idea?
Do you prefer another place to explain situations like this?"
PR introduces (a) breaking change(s): <no>
PR introduces (a) deprecation(s): <no>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
