RobertIndie commented on code in PR #1955: URL: https://github.com/apache/streampipes/pull/1955#discussion_r1335889487
########## installer/compose/docker-compose.quickstart.yml: ########## Review Comment: It seems better to be based on https://github.com/apache/streampipes/blob/dev/installer/compose/docker-compose.yml. This seems more lightweight. ########## installer/compose/upload.sh: ########## @@ -0,0 +1,64 @@ +#!/bin/bash +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + + +# Send a POST request and save the response as JSON + +# Check if SP_INITIAL_ADMIN_EMAIL is empty; if so, set USERNAME to a default value +if [ -z "$SP_INITIAL_ADMIN_EMAIL" ]; then + USERNAME="[email protected]" +else + USERNAME="$SP_INITIAL_ADMIN_EMAIL" +fi + +# Check if SP_INITIAL_ADMIN_PASSWORD is empty; if so, set PASSWORD to a default value +if [ -z "$SP_INITIAL_ADMIN_PASSWORD" ]; then + PASSWORD="admin" +else + PASSWORD="$SP_INITIAL_ADMIN_PASSWORD" +fi + +echo $USERNAME +echo $PASSWORD Review Comment: We don't need to echo them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
