tenthe commented on code in PR #2653:
URL: https://github.com/apache/streampipes/pull/2653#discussion_r1542439756
##########
streampipes-model/src/main/java/org/apache/streampipes/model/staticproperty/RemoteOneOfStaticProperty.java:
##########
@@ -52,7 +52,7 @@ public RemoteOneOfStaticProperty(String internalName, String
label, String descr
this.valueFieldName = valueFieldName;
this.labelFieldName = labelFieldName;
this.descriptionFieldName = descriptionFieldName;
- this.valueRequired = valueRequired;
+ this.optional = valueRequired;
Review Comment:
Does this have the right meaning here? Because if valueRequired=true, then
optional should be false, right?
Do we have to rename this variable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
