tenthe commented on code in PR #2691:
URL: https://github.com/apache/streampipes/pull/2691#discussion_r1584272639
##########
streampipes-model/src/main/java/org/apache/streampipes/model/deployment/DeploymentConfiguration.java:
##########
@@ -16,17 +16,35 @@
*
*/
-package org.apache.streampipes.manager.execution.endpoint;
+package org.apache.streampipes.model.deployment;
-import
org.apache.streampipes.commons.exceptions.NoServiceEndpointsAvailableException;
-import org.apache.streampipes.model.base.InvocableStreamPipesEntity;
+import org.apache.streampipes.model.extensions.svcdiscovery.SpServiceTag;
-public class ExtensionsServiceEndpointProvider {
+import java.util.HashSet;
+import java.util.Set;
- public String findSelectedEndpoint(InvocableStreamPipesEntity g) throws
NoServiceEndpointsAvailableException {
- return new ExtensionsServiceEndpointGenerator(
- g.getAppId(),
- ExtensionsServiceEndpointUtils.getPipelineElementType(g))
- .getEndpointResourceUrl();
+public class DeploymentConfiguration {
Review Comment:
And can we rename it to something like
ProcessingElementDeploymentConfiguration? Just to make it clear that it has
nothing to do with the actual StreamPipes deployment configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
