ittuann commented on code in PR #2871:
URL: https://github.com/apache/streampipes/pull/2871#discussion_r1604514568
##########
streampipes-client-python/streampipes/endpoint/api/version.py:
##########
@@ -109,11 +109,20 @@ def get(self, identifier: str, **kwargs) -> Resource:
identifier: str
Not supported by this endpoint, is set to an empty string.
+ Raises
+ ------
+ NotImplementedError
+ Non-empty 'identifier' is not supported by this endpoint. Please
set 'identifier' to an empty string.
+
Returns
-------
versions: Version
The specified resource as an instance of the corresponding model
class([Version][streampipes.model.resource.Version]). # noqa: 501
"""
+ if identifier != "":
+ raise NotImplementedError(
Review Comment:
Thank you for your feedback! I understand your point and will modify the
code as per your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
