tenthe commented on code in PR #3260:
URL: https://github.com/apache/streampipes/pull/3260#discussion_r1778042508
##########
streampipes-extensions/streampipes-sinks-internal-jvm/src/main/resources/org.apache.streampipes.sinks.internal.jvm.datalake/strings.en:
##########
@@ -29,3 +29,6 @@ schema_update.description=Update existing schemas with the
new one or extend the
dimensions_selection.title=Dimensions
dimensions_selection.description=Selected fields will be stored as dimensions.
+
+ignore_duplicates.title=Ignore duplicates
+ignore_duplicates.description=Fields having the same value than the previous
event are not stored. This only affects measurements, not tags.
Review Comment:
The new option should also be added to the documentation.md file
##########
streampipes-data-explorer-iotdb/src/main/java/org/apache/streampipes/dataexplorer/iotdb/DataExplorerManagerIotDb.java:
##########
@@ -56,7 +56,8 @@ public IDataExplorerSchemaManagement getSchemaManagement() {
}
@Override
- public ITimeSeriesStorage getTimeseriesStorage(DataLakeMeasure measure) {
+ public ITimeSeriesStorage getTimeseriesStorage(DataLakeMeasure measure,
boolean ignoreDuplicates) {
+ // TODO: ignoreDuplicates not yet supported for IotDB
Review Comment:
Can you remove this TODO and create an issue instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
