tenthe commented on PR #3401: URL: https://github.com/apache/streampipes/pull/3401#issuecomment-2577189464
Hi @RohitGavale, Thank you for updating your PR in #3402! I really appreciate your effort. To clarify, there’s no need to open a new PR for the requested changes—you can make the updates directly in this one. My earlier comment might have been unclear, sorry for that. I’d like to refine it: I didn’t mean for you to modify the other methods within the `DataLakeResourceV4` class. Instead, I was referring specifically to the TypeScript client that interacts with this REST interface. Could you please update the naming in the `datalake-rest.service.ts` file, particularly for the `dropSingleMeasurementSeries` method? Here’s my suggestion: - Let’s focus on addressing the required updates in this PR, keeping the scope manageable. - Changes to the naming of other interfaces can be handled in a separate issue or PR. Additionally, to resolve the failing tests for this PR, you’ll need to adapt the variable name in the `@DeleteMapping` annotation, as you already did in your other PR. I hope this comment is helpful. Thank you again for your work and contributions. Cheers, Philipp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
