luoluoyuyu commented on code in PR #3795: URL: https://github.com/apache/streampipes/pull/3795#discussion_r2463824587
########## streampipes-model/src/main/java/org/apache/streampipes/model/loadbalancer/PipelineInfo.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.streampipes.model.loadbalancer; + +import java.time.LocalDateTime; + +/** + * Information about a pipeline for load balancing operations. + */ +public class PipelineInfo { + + private String lockKey; + private PipelineStates pipelineState; + private Thread currentThread; + private LocalDateTime lockTime; + private Integer waitCount; Review Comment: delete ########## streampipes-commons/src/main/java/org/apache/streampipes/commons/constants/Envs.java: ########## @@ -84,13 +84,13 @@ public enum Envs { SP_SETUP_PROMETHEUS_ENDPOINT("SP_SETUP_PROMETHEUS_ENDPOINT", "false"), - SP_HEALTH_CHECK_INTERVAL_MS("SP_HEALTH_CHECK_INTERVAL_MS", "30000"), + SP_HEALTH_CHECK_INTERVAL_MS("SP_HEALTH_CHECK_INTERVAL_MS", "1000"), SP_HEALTH_CHECK_INITIAL_DELAY_MS("SP_HEALTH_CHECK_INITIAL_DELAY", "10000"), SP_LOG_FETCH_INTERVAL_MS("SP_LOG_FETCH_INTERVAL_MS", "60000"), - SP_HEALTH_SERVICE_MAX_UNHEALTHY_TIME_MS("SP_HEALTH_SERVICE_MAX_UNHEALTHY_TIME_MS", "60000"), + SP_HEALTH_SERVICE_MAX_UNHEALTHY_TIME_MS("SP_HEALTH_SERVICE_MAX_UNHEALTHY_TIME_MS", "1000"), Review Comment: The frequency is too high, use the original value ########## streampipes-extensions-api/src/main/java/org/apache/streampipes/extensions/api/locker/Lock.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.streampipes.extensions.api.locker; + +import java.util.concurrent.TimeUnit; + +/** + * Interface for pipeline locking operations. + * Provides methods to acquire and release locks for pipeline processing. + */ +public interface Lock { Review Comment: delete ########## streampipes-model/src/main/java/org/apache/streampipes/model/extensions/svcdiscovery/SpServiceTagPrefix.java: ########## @@ -23,9 +23,16 @@ public enum SpServiceTagPrefix { ADAPTER, DATA_STREAM, DATA_PROCESSOR, - DATA_SINK; + DATA_SINK, + SYSTEM; + Review Comment: Why add this tag ########## streampipes-model/src/main/java/org/apache/streampipes/model/loadbalancer/PipelineStates.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.streampipes.model.loadbalancer; + +/** + * Enumeration of pipeline states for load balancing operations. + */ +public enum PipelineStates { + + /** + * Pipeline is stopped. + */ + STOP, Review Comment: delete -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
