dominikriemer commented on code in PR #3873:
URL: https://github.com/apache/streampipes/pull/3873#discussion_r2454721374
##########
ui/src/app/connect/components/existing-adapters/existing-adapters.component.ts:
##########
@@ -252,7 +262,7 @@ export class ExistingAdaptersComponent implements OnInit,
OnDestroy {
const dialogRef: DialogRef<DeleteAdapterDialogComponent> =
this.dialogService.open(DeleteAdapterDialogComponent, {
panelType: PanelType.STANDARD_PANEL,
- title: 'Delete Adapter',
+ title: this.translate.instant('Delete Adapter'),
Review Comment:
Delete adapter
##########
ui/src/app/connect/components/existing-adapters/existing-adapters.component.ts:
##########
@@ -182,13 +188,15 @@ export class ExistingAdaptersComponent implements OnInit,
OnDestroy {
SpExceptionDetailsDialogComponent,
{
panelType: PanelType.STANDARD_PANEL,
- title: 'Adapter Status',
+ title: this.translate.instant('Adapter Status'),
Review Comment:
Adapter status
##########
ui/src/app/connect/dialog/start-all-adapters/all-adapter-actions-dialog.component.html:
##########
@@ -26,13 +26,18 @@
*ngIf="page === 'preview'"
>
<h4>
- You are about to {{ action ? 'start' : 'stop' }} the
- following adapters:
+ {{ 'You are about to' | translate }}
+ {{ action ? 'start' : 'stop' }}
+ {{ 'the following adapters:' | translate }}
Review Comment:
better to create two strings for these cases and translate the whole
sentence to ensure the translation is correct for languages with different
sentence structures.
##########
ui/deployment/i18n/de.json:
##########
@@ -355,6 +355,28 @@
"Allow anonymous access through public link": "Anonymen Zugang über einen
öffentlichen Link ermöglichen",
"URL": "URL",
"(no log messages available)": "(keine Protokollmeldungen verfügbar)",
+ "You are about to": "Sie sind im dabei",
Review Comment:
```suggestion
"You are about to": "Sie sind dabei",
```
?
##########
ui/src/app/connect/dialog/start-all-adapters/all-adapter-actions-dialog.component.html:
##########
@@ -42,16 +47,28 @@ <h5><b>Press 'Next' to start the process.</b></h5>
>
<div *ngFor="let status of actionStatus">
<h4>
- {{ action ? 'Starting adapter ' : 'Stopping adapter' }}
- {{ status.id + 1 }} of {{ adaptersToModify.length }}
({{
- status.name
- }})...{{ status.status }}
+ {{
+ action
+ ? ('Starting adapter' | translate)
+ : ('Stopping adapter' | translate)
+ }}
+ {{ status.id + 1 }} {{ 'of' | translate }}
+ {{ adaptersToModify.length }} ({{ status.name }})...{{
+ status.status
+ }}
</h4>
</div>
<div *ngIf="adaptersToModify.length === 0">
<h4>
- Sorry, there are no adapters that are currently
- {{ action ? 'idle.' : 'running.' }}
+ {{
+ 'Sorry, there are no adapters that are currently '
+ | translate
+ }}
+ {{
+ action
+ ? ('idle' | translate)
+ : ('running' | translate)
Review Comment:
Same as above
##########
ui/src/app/connect/components/adapter-configuration/start-adapter-configuration/start-adapter-configuration.component.ts:
##########
@@ -176,7 +178,7 @@ export class StartAdapterConfigurationComponent implements
OnInit {
this.checkAndApplyStreamRules();
const dialogRef = this.dialogService.open(AdapterStartedDialog, {
panelType: PanelType.STANDARD_PANEL,
- title: 'Adapter edit',
+ title: this.translateService.instant('Adapter edit'),
Review Comment:
Should this be 'Edit adapter'?
##########
ui/deployment/i18n/de.json:
##########
@@ -737,13 +768,24 @@
"Error in line {{rowNumber}}. Value for \"{{property}}\" is not supported.":
"Fehler in Zeile {{rowNumber}}. Wert für \"{{property}}\" wird nicht
unterstützt.",
"Error in line {{rowNumber}}. Value for \"{{property}}\" is not set.":
"Fehler in Zeile {{rowNumber}}. Wert für \"{{property}}\" ist nicht gesetzt.",
"Resources": "Ressourcen",
+ "Checking migrations for adapter {{adapterName}}": "Migrationen für Adapter
{{adapterName}} prüfen",
"Updating adapter {{adapterName}}": "Aktualisieren des Adapters
{{adapterName}}",
"Creating adapter {{adapterName}}": "Adapter erstellen {{adapterName}}",
+ "Your new data stream is now available in the pipeline editor.": "Ihr neuer
Datenstrom ist nun im Pipeline-Editor verfügbar.",
"Starting adapter {{adapterName}}": "Adapter starten {{adapterName}}",
"Your Assets were successfully added.": "Assets erfolgreich hinzugefügt.",
"Your Assets were successfully deleted.": "Assets erfolgreich gelöscht.",
+ "Creating pipeline to persist data stream": "Erstellen einer Pipeline zur
Aufrechterhaltung des Datenstroms",
Review Comment:
```suggestion
"Creating pipeline to persist data stream": "Erstellen einer Pipeline zum
Speichern der Daten",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
