dominikriemer commented on code in PR #3795:
URL: https://github.com/apache/streampipes/pull/3795#discussion_r2478874989
##########
streampipes-rest-extensions/pom.xml:
##########
@@ -75,6 +75,12 @@
<artifactId>junit-jupiter-api</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.streampipes</groupId>
Review Comment:
This module contains many things that are only used by the core service.
Can we extract the parts of the load balancer needed by both core and
extension services into a separate module?
Then we could avoid importing too much functionality from the core into the
extension services.
##########
streampipes-pipeline-management/src/main/java/org/apache/streampipes/manager/health/PipelineHealthCheck.java:
##########
@@ -224,30 +222,25 @@ private void addEndpoint(Map<String,
List<InvocableStreamPipesEntity>> endpointM
@Override
public void run() {
- this.checkAndRestorePipelineElements();
+ try {
+ this.checkAndRestorePipelineElements();
+ } catch (Exception e) {
+
Review Comment:
Should we log the exception here?
##########
streampipes-storage-api/src/main/java/org/apache/streampipes/storage/api/IPipelineStorage.java:
##########
@@ -26,4 +26,13 @@ public interface IPipelineStorage extends
CRUDStorage<Pipeline> {
List<String> getPipelinesUsingAdapter(String adapterId);
+ void storePipeline(Pipeline pipeline);
+
+ void updatePipeline(Pipeline pipeline);
Review Comment:
I think these methods can be removed and replaced by the methods offered by
`CRUDStorage`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
