tenthe commented on code in PR #4011:
URL: https://github.com/apache/streampipes/pull/4011#discussion_r2585679404
##########
ui/src/app/data-explorer-shared/components/charts/table/table-widget.component.ts:
##########
@@ -142,7 +142,7 @@ export class TableWidgetComponent
this.refreshColumns();
}
- onResize(width: number, height: number) {}
+ onResize(_width: number, _height: number) {}
Review Comment:
Is there a reason why the parameters have a _ prefix? Is the onResize method
always empty for all charts?
##########
streampipes-model/src/main/java/org/apache/streampipes/model/dashboard/DashboardItem.java:
##########
@@ -109,4 +113,37 @@ public Map<String, Object> getTimeSettings() {
public void setTimeSettings(Map<String, Object> timeSettings) {
this.timeSettings = timeSettings;
}
+
+ @Deprecated
Review Comment:
When can this be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
