Copilot commented on code in PR #4076:
URL: https://github.com/apache/streampipes/pull/4076#discussion_r2644917587
##########
ui/src/app/assets/components/asset-overview/asset-overview.component.ts:
##########
@@ -163,6 +163,8 @@ export class SpAssetOverviewComponent implements OnInit {
dialogRef.afterClosed().subscribe(ev => {
if (ev) {
+ this.loadAssets();
+ this.assetBrowserService.reloadAssetData();
Review Comment:
Inconsistent usage of the asset reload API across the codebase. This code
uses `reloadAssetData()` after asset creation (line 167), but the same file
uses `loadAssetData()` after asset deletion (line 197). Similarly,
`asset-details.component.ts` line 36 calls `loadAssetData()` directly after
saving. For better maintainability, consider either: (1) updating all external
calls to use the new `reloadAssetData()` method and marking `loadAssetData()`
as private, or (2) consistently using `loadAssetData()` everywhere if that's
the preferred approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
