Brijesh-Thakkar commented on code in PR #4082:
URL: https://github.com/apache/streampipes/pull/4082#discussion_r2656656621
##########
ui/src/app/assets/components/asset-overview/asset-overview.component.ts:
##########
@@ -112,10 +118,22 @@ export class SpAssetOverviewComponent implements OnInit {
}
loadAssets(): void {
+ console.log(
+ '[AssetOverview] loading assets with filter',
+ this.currentFilterIds,
+ );
this.assetService.getAllAssets().subscribe(result => {
this.existingAssets = result as SpAssetModel[];
this.dataSource.sort = this.sort;
this.dataSource.data = this.existingAssets;
+
+ // Apply filter if one exists after loading assets
+ if (
+ this.currentFilterIds &&
+ this.hasActiveFilter(this.currentFilterIds)
+ ) {
Review Comment:
git commit -m "Simplify asset filter presence check"
##########
ui/src/app/assets/components/asset-overview/asset-overview.component.ts:
##########
@@ -112,10 +118,22 @@ export class SpAssetOverviewComponent implements OnInit {
}
loadAssets(): void {
+ console.log(
+ '[AssetOverview] loading assets with filter',
+ this.currentFilterIds,
+ );
this.assetService.getAllAssets().subscribe(result => {
this.existingAssets = result as SpAssetModel[];
this.dataSource.sort = this.sort;
this.dataSource.data = this.existingAssets;
+
+ // Apply filter if one exists after loading assets
+ if (
+ this.currentFilterIds &&
+ this.hasActiveFilter(this.currentFilterIds)
+ ) {
Review Comment:
git commit -m "Simplify asset filter presence check"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
