tenthe commented on code in PR #4096:
URL: https://github.com/apache/streampipes/pull/4096#discussion_r2693435164
##########
streampipes-connect-management/src/main/java/org/apache/streampipes/connect/management/management/WorkerAdministrationManagement.java:
##########
@@ -47,23 +46,23 @@ public class WorkerAdministrationManagement {
private final IAdapterStorage adapterDescriptionStorage;
- private final AdapterHealthCheck adapterHealthCheck;
+ //private final AdapterHealthCheck adapterHealthCheck;
Review Comment:
```suggestion
```
##########
streampipes-connect-management/src/main/java/org/apache/streampipes/connect/management/management/WorkerAdministrationManagement.java:
##########
@@ -81,11 +80,11 @@ public void checkAndRestore(int retryCount) {
} else {
LOG.info("Max retries for running adapter operations reached, will do
unlock which might cause conflicts...");
AdapterOperationLock.INSTANCE.unlock();
- this.adapterHealthCheck.checkAndRestoreAdapters();
+ //this.adapterHealthCheck.checkAndRestoreAdapters();
}
} else {
AdapterOperationLock.INSTANCE.lock();
- this.adapterHealthCheck.checkAndRestoreAdapters();
+ //this.adapterHealthCheck.checkAndRestoreAdapters();
Review Comment:
```suggestion
```
##########
streampipes-connect-management/src/main/java/org/apache/streampipes/connect/management/management/WorkerAdministrationManagement.java:
##########
@@ -81,11 +80,11 @@ public void checkAndRestore(int retryCount) {
} else {
LOG.info("Max retries for running adapter operations reached, will do
unlock which might cause conflicts...");
AdapterOperationLock.INSTANCE.unlock();
- this.adapterHealthCheck.checkAndRestoreAdapters();
+ //this.adapterHealthCheck.checkAndRestoreAdapters();
Review Comment:
```suggestion
```
##########
streampipes-connect-management/src/main/java/org/apache/streampipes/connect/management/management/WorkerAdministrationManagement.java:
##########
@@ -47,23 +46,23 @@ public class WorkerAdministrationManagement {
private final IAdapterStorage adapterDescriptionStorage;
- private final AdapterHealthCheck adapterHealthCheck;
+ //private final AdapterHealthCheck adapterHealthCheck;
public WorkerAdministrationManagement(
IAdapterStorage adapterStorage,
AdapterMetrics adapterMetrics,
AdapterResourceManager adapterResourceManager,
DataStreamResourceManager dataStreamResourceManager
) {
- this.adapterHealthCheck = new AdapterHealthCheck(
- adapterStorage,
- new AdapterMasterManagement(
- adapterStorage,
- adapterResourceManager,
- dataStreamResourceManager,
- adapterMetrics
- )
- );
+// this.adapterHealthCheck = new AdapterHealthCheck(
+// adapterStorage,
+// new AdapterMasterManagement(
+// adapterStorage,
+// adapterResourceManager,
+// dataStreamResourceManager,
+// adapterMetrics
+// )
+// );
Review Comment:
```suggestion
```
##########
streampipes-commons/src/main/java/org/apache/streampipes/commons/constants/Envs.java:
##########
@@ -102,21 +102,21 @@ public enum Envs {
SP_PULSAR_URL("SP_PULSAR_URL", "pulsar://localhost:6650"),
- CPU_RESOURCE_WEIGHT("CPU_RESOURCE_WEIGHT", "1.0"),
- MEMORY_RESOURCE_WEIGHT("MEMORY_RESOURCE_WEIGHT", "1.0"),
-
- DIR_MEMORY_RESOURCE_WEIGHT("DIR_MEMORY_RESOURCE_WEIGHT", "1.0"),
- BANDWIDTH_IN_RESOURCE_WEIGHT("BANDWIDTH_IN_RESOURCE_WEIGHT", "1.0"),
- BANDWIDTH_OUT_RESOURCE_WEIGHT("BANDWIDTH_OUT_RESOURCE_WEIGHT", "1.0"),
- THRESHOLD_MIGRATOR_PERCENTAGE("THRESHOLD_MIGRATOR_PERCENTAGE", "20.0"),
- MIN_MIGRATOR_PERCENTAGE("MIN_MIGRATOR_PERCENTAGE", "20.0"),
- OVERLOADED_THRESHOLD_PERCENTAGE("OVERLOADED_THRESHOLD_PERCENTAGE", "85"),
- HISTORY_RESOURCE_PERCENTAGE("HISTORY_RESOURCE_PERCENTAGE", "0.9"),
-
MSG_RATE_DIFFERENCE_MIGRATOR_THRESHOLD("MSG_RATE_DIFFERENCE_MIGRATOR_THRESHOLD",
"85"),
- LOAD_TARGET_STD("LOAD_TARGET_STD", "25.0"),
- SELECTOR("SELECTOR", "WeightedRandomSelector"),
- MIGRATOR("MIGRATOR", "ThresholdMigrator"),
- LOAD_MANAGER_ENABLE("LOAD_MANAGER_ENABLE", "true"),
+ CPU_RESOURCE_WEIGHT("SP_CPU_RESOURCE_WEIGHT", "1.0"),
Review Comment:
Can we also refactor the variable names to use 'SP_' as a prefix to be
consistent with the other variable names
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
