Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/67#discussion_r16182534
  
    --- Diff: 
streams-contrib/streams-provider-datasift/src/main/java/org/apache/streams/datasift/processor/CleanAdditionalPropertiesProcessor.java
 ---
    @@ -0,0 +1,62 @@
    +package org.apache.streams.datasift.processor;
    +
    +import com.fasterxml.jackson.databind.JsonNode;
    +import com.fasterxml.jackson.databind.ObjectMapper;
    +import com.fasterxml.jackson.databind.node.ObjectNode;
    +import com.fasterxml.jackson.datatype.jsonorg.JsonOrgModule;
    +import com.google.common.collect.Lists;
    +import org.apache.streams.core.StreamsDatum;
    +import org.apache.streams.core.StreamsProcessor;
    +import org.apache.streams.jackson.StreamsJacksonMapper;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.Map;
    +
    +/**
    + * HACK PROCESSOR.  Changes need to be made in apache streams to fix this 
issue long term.
    --- End diff --
    
    I've observed a lot of unwanted serialization artifacts from this module, 
most of which can be fixed by including this processor.  Now that the logic for 
fixing those artifacts is part of the module, the situation has improved - the 
long term concern is that it is too easy to overuse/misuse jackson, compounded 
when working with objects from third-party projects that were built for 
projects other than Apache Streams.  I don't have a good answer to propose at 
the moment - just wanted a note to designate that the class shouldn't be needed 
and should be deleted once the root cause is isolated and corrected.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to