[ 
https://issues.apache.org/jira/browse/STREAMS-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105534#comment-14105534
 ] 

ASF GitHub Bot commented on STREAMS-152:
----------------------------------------

Github user rbnks commented on the pull request:

    https://github.com/apache/incubator-streams/pull/71#issuecomment-52944878
  
    :+1:  This looks good.  Although this code is getting messy.  I think we 
probably want to look to refactoring this code out and creating mapping objects 
that will allow user to implement how the index/type/id are set.  We can create 
a default one that works the same as it currently does, but allow users to 
override it with custom ones.


> Add a flag that forces use of Elasticsearch Configuration
> ---------------------------------------------------------
>
>                 Key: STREAMS-152
>                 URL: https://issues.apache.org/jira/browse/STREAMS-152
>             Project: Streams
>          Issue Type: Task
>            Reporter: Robert Douglas
>
> Add a flag that forces use of Elasticsearch Configuration



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to