[ 
https://issues.apache.org/jira/browse/STREAMS-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216412#comment-14216412
 ] 

ASF GitHub Bot commented on STREAMS-216:
----------------------------------------

Github user rbnks commented on the pull request:

    https://github.com/apache/incubator-streams/pull/130#issuecomment-63503329
  
    ```Tests run: 92, Failures: 4, Errors: 72, Skipped: 1
    Failed tests: 
      DatumStatusCounterTest.testConstructor:59->Assert.fail:88 Constructor 
Threw Exception : javax.management.InstanceAlreadyExistsException: 
org.apache.streams.local:type=DatumCounter,name=test_id,identifier=Unknown_Stream,startedAt=-1
      StreamsTaskCounterTest.testConstructor:57->Assert.fail:88 Constructor 
threw error : javax.management.InstanceAlreadyExistsException: 
org.apache.streams.local:type=StreamsTaskCounter,name=test_id,identifier=null,startedAt=-1
      
ThroughputQueueSingleThreadTest.testMultipleMBeanRegistrations:238->Assert.fail:88
 Failed to register MXBean : Format specifier 's'
      ThroughputQueueSingleThreadTest.testMBeanRegistration:217->Assert.fail:88 
Failed to register MXBean : Format specifier 's'
    
    Tests in error: 
      
LocalStreamBuilderTest.testBasicLinearStream1:132->linearStreamNonParallel:183->removeRegisteredMBeans:93
 » MissingFormatArgument
      LocalStreamBuilderTest.testStreamIdValidations:110 » NullPointer
      
LocalStreamBuilderTest.testBasicLinearStream2:137->linearStreamNonParallel:183->removeRegisteredMBeans:93
 » MissingFormatArgument
      
LocalStreamBuilderTest.testBasicMergeStream:246->removeRegisteredMBeans:93 » 
MissingFormatArgument
      
LocalStreamBuilderTest.testParallelLinearStream1:220->removeRegisteredMBeans:93 
» MissingFormatArgument
    ...
    ```
    
    There are failed test in your pull request.


> Update JMX beans so that we have identifying information
> --------------------------------------------------------
>
>                 Key: STREAMS-216
>                 URL: https://issues.apache.org/jira/browse/STREAMS-216
>             Project: Streams
>          Issue Type: Sub-task
>            Reporter: Robert Douglas
>
> We need to have all of our JMX beans created with identifying information so 
> we know which stream it is associated with. LocalStreamBuilder needs to take 
> in a String identifier which will then be used. This is essential in order 
> for us to make sense of the messages that we receive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to