Github user robdouglas commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/155#discussion_r21403865
--- Diff:
streams-contrib/streams-provider-datasift/src/test/java17/org/apache/streams/datasift/serializer/DatasiftEventClassifierTest.java
---
@@ -50,7 +57,10 @@ public void testTwitterDetection() throws Exception {
@Test
public void testInstagramDetection() throws Exception {
- Scanner scanner = new
Scanner(DatasiftActivitySerializerTest.class.getResourceAsStream("/instagram_datasift_json.txt"));
+
--- End diff --
This pattern is repeated several times, would it make sense to abstract it
out to a utility function where the user could pass in the resource name and
get back a Scanner object? That way if we needed to change encodings again for
some reason, it wouldn't be as painful
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
