[
https://issues.apache.org/jira/browse/STREAMS-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239540#comment-14239540
]
ASF GitHub Bot commented on STREAMS-243:
----------------------------------------
Github user rbnks commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/162#discussion_r21535322
--- Diff:
streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3PersistWriter.java
---
@@ -249,26 +250,32 @@ public void prepare(Object configurationObject) {
// Connect to S3
synchronized (this) {
- // if the user has chosen to not set the object mapper, then
set a default object mapper for them.
- if(this.objectMapper == null)
- this.objectMapper = new ObjectMapper();
+ try {
+ // if the user has chosen to not set the object mapper,
then set a default object mapper for them.
+ if (this.objectMapper == null)
+ this.objectMapper = new ObjectMapper();
--- End diff --
What is the reason for not using the StreamsJacksonMapper?
> S3 Persist Writer does not flush or shutdown on stream shutdown
> ---------------------------------------------------------------
>
> Key: STREAMS-243
> URL: https://issues.apache.org/jira/browse/STREAMS-243
> Project: Streams
> Issue Type: Bug
> Reporter: Steve Blackmon
>
> S3 Persist Writer does not seem to flush or shutdown on stream shutdown,
> which has the side-effect of not allowing the stream process to close.
> When cleanUp() is called, the writer should flush and terminate gracefully.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
