Github user robdouglas commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/162#discussion_r21535867
  
    --- Diff: 
streams-contrib/streams-amazon-aws/streams-persist-s3/src/main/java/org/apache/streams/s3/S3PersistWriter.java
 ---
    @@ -249,26 +250,32 @@ public void prepare(Object configurationObject) {
             // Connect to S3
             synchronized (this) {
     
    -            // if the user has chosen to not set the object mapper, then 
set a default object mapper for them.
    -            if(this.objectMapper == null)
    -                this.objectMapper = new ObjectMapper();
    +            try {
    +                // if the user has chosen to not set the object mapper, 
then set a default object mapper for them.
    +                if (this.objectMapper == null)
    +                    this.objectMapper = new ObjectMapper();
    --- End diff --
    
    That was the mapper that was being used previously, just kept it the same. 
Does StreamsJacksonMapper have any performance/functional enhancements over the 
stock ObjectMapper?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to