Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/202#discussion_r27688659
  
    --- Diff: 
streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/converter/TwitterFollowActivityConverter.java
 ---
    @@ -0,0 +1,84 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.streams.twitter.converter;
    +
    +import com.google.common.collect.Lists;
    +import org.apache.commons.lang.NotImplementedException;
    +import org.apache.streams.data.ActivityConverter;
    +import org.apache.streams.exceptions.ActivityConversionException;
    +import org.apache.streams.pojo.json.Activity;
    +import org.apache.streams.pojo.json.ActivityObject;
    +import org.apache.streams.pojo.json.Provider;
    +import org.apache.streams.twitter.pojo.Follow;
    +import org.apache.streams.twitter.converter.util.TwitterActivityUtil;
    +
    +import java.io.Serializable;
    +import java.util.List;
    +
    +public class TwitterFollowActivityConverter implements 
ActivityConverter<Follow>, Serializable {
    +
    +    public TwitterFollowActivityConverter() {
    +    }
    +
    +    private static TwitterFollowActivityConverter instance = new 
TwitterFollowActivityConverter();
    +
    +    public static TwitterFollowActivityConverter getInstance() {
    +        return instance;
    +    }
    +
    +    public static Class requiredClass = Follow.class;
    +
    +    @Override
    +    public Class requiredClass() {
    +        return requiredClass;
    +    }
    +
    +    @Override
    +    public String serializationFormat() {
    +        return null;
    +    }
    +
    +    @Override
    +    public Follow fromActivity(Activity deserialized) throws 
ActivityConversionException {
    --- End diff --
    
    I don't know of any converters which have implementations to go from 
Activity/ActivityObject to external network format - not because of difficulty 
it just hasn't been a priority yet.  
    
    However, there are many fromActivity implementations that would be more 
important that this one, since org.apache.streams.twitter.pojo.Follow is a POJO 
internal to streams-provider-twitter (there is no twitter API that uses that 
bean).
    
    I will create a ticket to implement fromActivity throughout this module and 
make an effort to roll that into the next release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to