[ 
https://issues.apache.org/jira/browse/STREAMS-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963907#comment-14963907
 ] 

ASF GitHub Bot commented on STREAMS-371:
----------------------------------------

Github user steveblackmon commented on a diff in the pull request:

    https://github.com/apache/incubator-streams/pull/263#discussion_r42414929
  
    --- Diff: 
streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterFollowingProviderTask.java
 ---
    @@ -144,6 +165,57 @@ else if( endpoint.equals("friends") )
             } while (curser != 0 && keepTrying < 10);
         }
     
    +    private void collectIds(Long id) {
    +        int keepTrying = 0;
    +
    +        long curser = -1;
    +
    +        do
    +        {
    +            try
    +            {
    +                twitter4j.IDs ids = null;
    +                if( endpoint.equals("followers") )
    +                    ids = 
client.friendsFollowers().getFollowersIDs(id.longValue(), curser, max_per_page);
    +                else if( endpoint.equals("friends") )
    +                    ids = 
client.friendsFollowers().getFriendsIDs(id.longValue(), curser, max_per_page);
    +
    +                Preconditions.checkNotNull(ids);
    +                Preconditions.checkArgument(ids.getIDs().length > 0);
    +
    +                for (long otherId : ids.getIDs()) {
    +
    +                    try {
    +                        Follow follow;
    +                        if( endpoint.equals("followers") ) {
    +                            follow = new Follow()
    +                                    .withFollowee(new User().withId(id))
    +                                    .withFollower(new 
User().withId(otherId));
    +                        } else if( endpoint.equals("friends") ) {
    +                            follow = new Follow()
    +                                    .withFollowee(new 
User().withId(otherId))
    +                                    .withFollower(new User().withId(id));
    +                        } else {
    +                            throw new Exception("endpoint must be set to 
'friends' or 'followers'");
    --- End diff --
    
    the precondition was already being checked, just outside the method where 
the compiler couldn't trace.  changed to a not null precondition here.


> Allow use of ids endpoints in TwitterFollowingProvider
> ------------------------------------------------------
>
>                 Key: STREAMS-371
>                 URL: https://issues.apache.org/jira/browse/STREAMS-371
>             Project: Streams
>          Issue Type: Improvement
>            Reporter: Steve Blackmon
>            Assignee: Steve Blackmon
>
> Allow use of ids endpoints in TwitterFollowingProvider
> These ids have higher throughput than the endpoints the provider currently 
> uses, at the cost of getting only IDs rather than full profiles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to