I've submitted a new patch with your suggestion. Niall
----- Original Message ----- From: "David Graham" <[EMAIL PROTECTED]> To: "Struts Developers List" <[EMAIL PROTECTED]> Sent: Thursday, April 15, 2004 4:33 AM Subject: Re: Url Validation Configuration Options > > --- Ted Husted <[EMAIL PROTECTED]> wrote: > > Any thoughts on this one? > > The patch looks reasonable to me although the conversion from List to > String[] could be made simpler: > > String[] schemes = new String[schemeList.size()]; > schemeList.toArray(schemes); > > instead of: > String[] schemes = null; > ... > schemes = (String[])schemeList.toArray(new String[schemeList.size()]); > > or maybe skip the List to array step by using > StringTokenizer.countTokens(). > > David > > > > > http://issues.apache.org/bugzilla/show_bug.cgi?id=28148 > > > > "The current url validation in struts (validateUrl method in > > FieldChecks) only > > uses the default url configuration options. > > > > "I am attaching a patch that will allow the following options to be set > > in the > > validation.xml file using variables." > > > > <snip/> > > > > -Ted. > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > __________________________________ > Do you Yahoo!? > Yahoo! Tax Center - File online by April 15th > http://taxes.yahoo.com/filing.html > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
