James Holmes wrote:

The problem is/was that the <s:base> tag was rendering invalid <base>
element:

The JSPs in the struts-faces war (i.e. logon.jsp) have an <s:base
id="base"/> that generates the following:

<base href="/struts-faces/logon.faces" />

The href should have a fully qualified url (i.e. http://...) right?  This
causes the browser to not be able to find the stylesheet for the page.




Not only should it be absolute (although the browser I tried it with actually still worked right with a server relative path), it needs to be the path of the JSP page itself. That isn't critical if you use extension mapping for FacesServlet, but it really matters if you use prefix mapping, where the generated HREF would have been "/struts-faces/faces/logon.jsp" and therefore added a directory level.


I presume you have fixed after seeing your last commit?



Yep, it should be fixed now ... can you give it a try?

-James



Craig


-----Original Message-----
From: Craig McClanahan [mailto:[EMAIL PROTECTED] Sent: Wednesday, July 07, 2004 8:33 PM
To: Struts Developers List
Subject: Re: cvs commit:
jakarta-struts/contrib/struts-faces/src/java/org/apache/struts/faces/taglib
AbstractFacesTag.java BaseTag.java ErrorsTag.java HtmlTag.java
MessageTag.java StylesheetTag.java WriteTag.java


James Holmes wrote:



Just curious if these changes fix the problem with the broken <s:base> tag?
Basically the tag was outputting and invalid "href" attribute on the
generated "base" tag.

This is a problem almost everyone was experiencing.  Myself included.






Sorry to be dense, but *what* broken output? What's wrong with it? Is there a bugzilla report on this?


Both example apps work for me on Tomcat 4.1.29 and 5.0.25. But that was true before today's changes too; and I didn't change anything that should affect the URL being created.



-James





Craig


--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to