DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=31230>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=31230 Multiple classes using deprecated DefinitionsUtil class ------- Additional Comments From [EMAIL PROTECTED] 2004-10-07 20:08 ------- The proposed change to TilesRequestProcessor would cause backward compatibility issues if anyone is relying on the fact that storing a defintion in the Request under the ACTION_DEFINITION key causes it to be used. Personally I wasn't aware of this behaviour - but since its there should we continue to support it or not? If the answer is that we should support it then we probably need to move the get/set/removeActionDefinition methods to TilesUtils - and in that scenario then the simplest change to DefinitionDispatcherAction would be to just switch from using DefinitionsUtil to TilesUtil. If we don't care about continuing to support it, then Sean's changes look good. It would be good if someone who knows more about the thinking behind that bit of the code could comment. I also wasn't aware that Tiles still supported using init-params in the web.xml until I saw Sean's patch for TilesPlugin. Since most of the configuration that used to use init-params has been moved into the struts-config.xml (including Tiles through the PlugIn) then I think rather than change the code as Sean's proposing, we should just remove it. Niall --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
