We did just get Commons Resources promoted out of the sandbox, and I'm hopeful that we'll get that puppy released soon. Finally!
I think I'll go ahead and do it anyway. It will only take a few minutes, and then it will be done no matter how long it takes to get the conversion to commons-resources done -- I'm assuming it will be a someone complex conversion...
Joe
-- Martin Cooper
On Fri, 3 Dec 2004 11:37:38 -0800 (PST), David Graham <[EMAIL PROTECTED]> wrote:We didn't do it earlier because we wanted to use commons-resources for message passing. That hasn't happened so we may as well add the validateForm() method and deprecate validate().
David
--- Joe Germuska <[EMAIL PROTECTED]> wrote:
> In order to push forward on full deprecation of ActionErrors, I
> propose adding the following method to ActionForm:
>
> public ActionMessages validateForm(ActionMapping mapping,
> HttpServletRequest request) {
>
> return validate(mapping, request);
>
> }
>
> and then changing one line in the Request Processing chain:
>
> ActionMessages errors = form.validate(mapping, request);
> to
> ActionMessages errors = form.validateForm(mapping, request);
>
> I'm not sure now why we haven't done this earlier. Someone suggested
> it on one of the lists a while ago and it seemed clear once I saw it,
> but I haven't had time to do anything about it.
>
> My inclination is to do this only on the 1.3 (HEAD) branch, and to
> make the change in RequestProcessor.java even though it is slated for
> obsolescence, and then also to make the change in
> o.a.s.chain.AbstractValidateActionForm (which actually still uses
> ActionErrors, actually.)
>
> If it didn't seem strange that it hasn't been done already, I might
> have just gone ahead and done it without raising the question -- so
> I'm wondering if I'm missing something?
>
> Joe
>
> --
> Joe Germuska
> [EMAIL PROTECTED]
> http://blog.germuska.com
> "Narrow minds are weapons made for mass destruction" -The Ex
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
__________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--
Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com "Narrow minds are weapons made for mass destruction" -The Ex
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
