For the daring, I've put up another round of my work in progress at http://www.apache.org/~germuska/struts-1.3.0-dev/
I fixed some fairly boneheaded problems with the last version and got it at least running through the mailreader example app, although then I realized that I didn't have a taglibs jar and it was time for bed! But I haven't changed anything in the "forward" processing, so I think that it's in pretty good shape.
The main issue/question/hitch/dilemma now is to figure out how to deal with the historical fact that values were stored in request or session scope, but now are intended to be stored in the ActionContext. As it is now, I have the ServletActionContext both calling superclass methods (for storing the values in the ChainContext) and putting things in the request or session scope. This has possible synchronization problems in that the reads do not test the request/session scope -- they assume that the context already has the right value. Maybe it should skip the superclass version and only move things in and out of the request and session scopes.
I'm also wondering right now whether it would be more correct to construct the ActionContext class in the ComposableRequestProcessor, thereby committing to it's API for all commands, or whether to stick with the looser approach currently in place. I haven't thought that much about the distinctions between an ActionContext and a ViewContext, or whether we really need to distinguish them or whether a single one can serve both roles.
Another side note: there are a couple of base commands which have dependencies on the Servlet API -- they are the ones that deal with creating Actions and Forms, both of which also have dependencies on the Servlet API. I'm wondering if we should push that into abstractions to continue the pattern of having Servlet dependencies in the "servlet" subpackage, or whether Struts' own API dependencies make that not necessary or not worthwhile.
I think I'll have this stuff stable enough to commit within the week, so now is a particularly good time to speak up about design choices and the like...
Joe
-- Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com "Narrow minds are weapons made for mass destruction" -The Ex
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
