DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=34218>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=34218


[EMAIL PROTECTED] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement




------- Additional Comments From [EMAIL PROTECTED]  2005-04-01 08:01 -------
Changing this to an enhancement request.

It would be better to be specific about which methods you want changing (rather 
than saying "methods like...") and what explain what your requirements actually 
are.

For example, making calculateMatchValues() in SelectTag doesn't really add much 
value IMO. You could override doStartTag() and duplicate the four lines there, 
implementing your own calculate method. If you explain your requirement for 
determining the match values, then maybe we could add a real improvement rather 
than just saving four lines.

In the case of the selectTag() method in OptionTag it is just getting hold of 
the parent SelectTag - what would you want to different here - what other 
SelectTag, other than the parent would you want to get hold of? The real 
functionality is in the isMatched(value) method in that parent SelectTag which 
gets called and is public and can be overriden.

In the case of the evaluateExpressions() methods in the EL Tags you can 
currently easily do what you want, by overridng the doStartTag() method. Either 
calling super.doStartTag() if you want to execute whats in evaluateExpressions
() or not if you don't. Since the doStartTag() methods contain nothing else 
except calling evaluateExpressions() I see not benefit in this.

To summarise then, IMO you need to be specific about the methods you want 
changing and you need to explain you're requirements for changing the standard 
behaviour.

Niall


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to