DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=19346>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=19346





------- Additional Comments From [EMAIL PROTECTED]  2005-04-17 21:12 -------
(In reply to comment #2)
> I'm not comfortable with having the ActionForm maintain a collection of errors
> over time; it seems risky when you might have a "session" scoped ActionForm. 

Quite contrary, this is exactly why collection of errors SHOULD be maintained in
session-scoped action form: to survive redirects. This exactly what I do in my
projects. Of course, now we face another issue: how and when to remove unneeded
stuff from a form bean. But even if these messages would not be removed, the
session size for each connection will not grow indefinetely, because there is
only one message object per session. I think that usability is much more
important than session size.

> How would one be clear on the semantics of when a new ActionMessages should be
> created vs. when the existing one should be augmented?

Simple: Messages should be kept and shown once again, when page is requested by
browser, until new input comes in, then messages should be cleaned and should
get accumulated again according to new input data and model update. This
approach requires cleaner development, with using POST for input only, and GET
for obtaining output only. Works like a charm in my projects.

> There has been plenty of talk about how to adjust ActionForm to remove the
> direct dependency on the deprecated ActionErrors class; I believe the best 
> route
> is to pass in an ActionContext object (new in Struts 1.3) and return void;

Exactly! Returning void, that is what I do. I use session-scoped form bean and
accumulate errors in the collection. Then I do redirect, and load a page with
GET, restoring saved messages from form bean to request object.

See more at:
  http://www.theserverside.com/articles/article.tss?l=RedirectAfterPost
  http://www.theserverside.com/articles/article.tss?l=RedirectAfterPost2
  http://www.jroller.com/comments/javadujour/Weblog/why_struts_form_bean_sucks
  http://www.superinterface.com/redirectafterpost.htm

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to