At 1:40 AM -0700 4/30/05, rmanchu wrote:
hi

<set-property key="" value="" />

have gone thru the source and (if i'm not mistaken) i found the properties set in action mappings are never used within struts, its only for the user to set them and use them.

This is true, for now, although one of the motivations was to make it possible for users to use the DispatchChainAction, which requires two config parameters (command and catalog) without binding users to a particular subclass of ActionMapping -- so it's entirely possible that Struts will begin using it.


Just thought I'd point that out.

I'm using it in development for non-framework stuff, though, and it's pretty handy. I mean, what was more boring that writing a custom subclass of ActionMapping? And also, in the chain model, you are much more likely to have multiple steps in the request process which each want per-action-mapping config details, so you would be likely to run into problems if each step required a specific type -- the inheritance hierarchy would become totally unmanageable.

by this logic FormBeanConfig and FormPropertyConfig could do this also, quite trivially.

guys, could this go into struts 1.3? if you think its a good idea, i'd be happy to log this as a bug/enhancement and upload a patch.

I'm happy to see this general pattern extended to any config element. The cost is pretty low, and in fact, consistency would be nice -- users shouldn't have to worry about where they can use the "key" attribute in <set-property>. Probably we should add some interface to cleanly represent the nature of "HavingArbitraryProperties"... although a good name is eluding me at the moment.


While I haven't needed it yet, ForwardConfig was my next likely candidate for this extension. Off the top of my head I can't think of anything which "shouldn't" have it. I'm just curious what you were thinking about doing with it in the form config objects?

Joe

--
Joe Germuska [EMAIL PROTECTED] http://blog.germuska.com "Narrow minds are weapons made for mass destruction" -The Ex


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to