DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT <http://issues.apache.org/bugzilla/show_bug.cgi?id=34445>. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=34445 ------- Additional Comments From [EMAIL PROTECTED] 2005-05-04 02:08 ------- Firstly, the suggested fix is dependant on features in Commons FileUpload that have not yet been released. Therefore this patch cannot be considered until there has been a release of FileUpload and Struts has changed its depedency to the new version. Secondly, I agree with Martin regarding ParameterParser. From what I see, the solution is duplicating the logic in DiskFileItem's getString() method, which calls the getCharSet() method to parse the content type to determine the charset. Maybe the getCharset() method should be part of the FileItem interface (or getCharacterEncoding() to keep it in line with the Request's method) and that way the solution then becomes simple.... String encoding = item.getCharacterEncoding(); if (encoding == null) { encoding = request.getCharacterEncoding(); } Whatever the solution though, if the fix for Bug 20813 is supposed to enable FileUpload to handle item specific character encodings, then it seems wrong to me to have to duplicate part of that solution in Struts. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
