On 11/14/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Author: craigmcc > Date: Mon Nov 14 17:53:40 2005 > New Revision: 344288 > > URL: http://svn.apache.org/viewcvs?rev=344288&view=rev > Log: > [37477] Prefix directory names starting with a digit > <snip/> > viewId = viewId.replace('/', '$'); > if (reserved.contains(viewId)) { > + return "_" + viewId; > + } else if ((viewId.length() > 0) && > Character.isDigit(viewId.charAt(0))) { > return "_" + viewId; <snap/>
Craig, I had thought of something else, and the first part of the compound condition above brought it back to me. The DefaultViewControllerMapper algorithm is beautiful in its simplicity, but also imposes a few restrictions on the naming of views. I understand that the ViewControllerMapper can be easily replaced, but I suspect many of us will be using the default impl. Best practices such as: * Not having a view placed at context root with just digits in the filename * Not having a hyphen in the filename might serve as a nice heads-up. I can draft a patch for Javadoc, is that where you'd post those? -Rahul --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
