I was wondering where I might hack the code when I saw this in
TilesUtilImpl:
<snip>
if (definition == null) {
if (!factory.isLocaleProcessed(request.getLocale())) {
// FIXME This will modify the factory as well as the
definitions
// but we are only locking the definitions.
//
// We'll have to refactor again to remove this issue.
synchronized (definitions) {
factory.addDefinitions(definitions,
request.getLocale());
}
}
definition = definitions.getDefinition(
definitionName, request.getLocale());
}
</snip>
So you assume that if a "definition" is not taken in the "normal" way, you
have to take a definition only on the base of a Locale? And if you want to
store the locale in the session? And if you want to return different
definitions with other criteria?
With other investigations I noticed that the old DefinitionsFactory.init
method had a ServletRequest and a ServletContext parameter. Why did you
remove it?
I hope that with the hurry of refactoring you are not killing the original
intent of Cedric.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
