Confirmed. That change did the trick for the "} else {" issues.
In r375966, I re-enabled the CURLY and Whitespace modules, with one other tweak.
Here's a change that Jalopy makes that Checkstyle didn't like:
- this(key, new Object[]{value0, value1});
+ this(key, new Object[] { value0, value1 });
When Checkstyle sees this, it warns
"{ followed by whitespace"
IDEA calls The construct is an "array initializer brace". By default
IDEA omits the spaces, but can be configured to add them instead, as
Jalopy is doing. So, I changed the Checkstyle configuration to allow
whitespace in array initializers, but left the checks for the other
tokens intact.
We seem to be good to go now. Using the current Jalopy and Checkstyle
configurations, there are still 1604 errors reported for the Action
subproject, but they all look like errors that need to be tended by a
developer.
One other thing. We now have two style-related configuration files in build
* jalopy-struts.xml
* struts_checks.xml
:) Can we choose a consistent naming convention for these files? :)
I would have done so myself, but I wasn't sure if I could just rename
the file in the main build folder and have the change cascade to the
other subprojects, or whether there was something else to do.
-Ted.
On 2/7/06, Wendy Smoak <[EMAIL PROTECTED]> wrote:
> On 2/7/06, Wendy Smoak <[EMAIL PROTECTED]> wrote:
>
> > I'd like to get "} else {" to stay on one line before we run Jalopy
> > against the other sub-projects. That's our convention, inherited
> > from Sun, and it should be a simple change to the configuration file.
>
> I *think* r375843 fixes this. I'm not certain, because the laptop has
> inexplicably started reporting the same error I mentioned earlier. It
> looks like Maven isn't setting the classpath before running the Jalopy
> Ant task. I'll try it tomorrow at work, but I'm running out of
> computers!
>
> --
> Wendy
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
