One other thing.  I believe we should change the suite() method in
AbstractJsfTestCase to return new TestSuite().

I had an abstract test class of my own that extended
AbstractJsfTestCase but I didn't have the suite method thinking - hey
this is abstract anyways so what is there to test.  Well maven2 threw
an assertion error that there were no test methods in the class.  I
only had this with maven2.  When running in the IDE - no problems.

I believe Shale will have the same problem when it eventually switches
to maven2 for the build.  An empty TestSuite seems to do the trick
though.

Sean

On 2/18/06, Craig McClanahan <[EMAIL PROTECTED]> wrote:
> On 2/18/06, Sean Schofield <[EMAIL PROTECTED]> wrote:
> >
> > I believe the problem I was not running the entire test suite of
> > myfaces tests in my IDE.  When I ran them in Maven, I believe an
> > earlier test was calling the get method for the RenderKitFactory and
> > therefore loading the default one into memory.  Apparently you are not
> > allowed to set a new one (as the setup in the AbstractJsfTestCase
> > attempts to do) once the getter is called.
> >
> > I changed the struts code to releaseFactories() in the setup method to
> > ensure you are able to set the factories as anticipated.
>
>
> +1.
>
> That's also something that might make sense as an application shuts down, in
> order to prevent potential memory leaks.  I'll take a look at that.
>
> Sean
> >
> > ps. Nice work on this test stuff.  I think we are going to convert all
> > of the MyFaces tests to use it!
>
>
> Cool!  I'm glad it's helpful.
>
> Craig
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to